Re: [Chromium-dev] mothership clean-ups

[Brian P. <br...@tu...>]

Brian Paul wrote:
> 
> I've come to realize that some of the newer config options I've
> added (like 'track_window_size', 'match_window_title', etc) are
> really app-node options, not mothership options.
> 
> Thus, they should be set with appNode.Conf('track_window_size', 1)
> instead of cr.Conf('track_window_size', 1).
> 
> I found that there's no support in mothership.py for app-node config
> options as there is for server/network nodes.  That was easily
> implemented.  Then I realized there's already a few config options
> for application nodes but they're currently implemented as special
> functions:
> 
>     appNode.StartDir(crbindir)
>     appNode.ClientDLL("some directory")
> 
> These options are queried from the app faker with crMothership-
> GetStartDir() and crMothershipGetClientDLL().
> 
> What I'd like to do is replace these functions with a generic
> mechanism.  So we'd instead set those options with:
> 
>     appNode.Conf('start_dir', crbindir)
>     appNode.Conf('client_dll', "some directory")
> 
> and query them from the app faker with crMothershipGetFakerParam(),
> just like the server options work.  Of course, we can keep the old
> StartDir() and ClientDLL() functions for backward compatiblity for
> a while.
> 
> I think these are reasonable changes.  I'll be able to chop some
> code out of mothership.py, client.c, etc. and add some new options.
> I won't check in any of these changes until next week in case anyone
> sees a problem.

OK, I've checked in my changes now.  Here's a summary.

These options used to be mothership options, but are now app-node
options:

	track_window_size
	minimum_window_size
	match_window_title
	show_cursor

So instead of using cr.Conf('track_window_size', 1) you'll call
appNode.Conf('track_window_size', 1).

Application nodes also have these config options:

config option		equivalent function
----------------------------------------------------------
application 
	appNode.Application('atlantis')
start_dir 
	appNode.StartDir(crbindir)
client_dll 
	appNode.ClientDLL('some directory')
spu_dir 
		appNode.SPUDir('some directory')


All existing config files should work as-is.  Deprecated mothership options
will be applied to the app nodes and a notice message will be printed to
stdout.  The html docs have been updated to reflect these changes.

I'll be checking in corresponding changes to the graphical config tool soon.

-Brian