#388 STM32 CAN broadcast typo

closed-fixed
2014-05-09
2013-03-03
wild-boar
No

The flags for the second RX FIFO should be 2 instead of 1 (which is the same as the first). The patch against trunk:

Index: os/hal/platforms/STM32/can_lld.c

--- os/hal/platforms/STM32/can_lld.c (revision 5348)
+++ os/hal/platforms/STM32/can_lld.c (working copy)
@@ -187,7 +187,7 @@
chSysLockFromIsr();
while (chSemGetCounterI(&canp->rxsem) < 0)
chSemSignalI(&canp->rxsem);
- chEvtBroadcastFlagsI(&canp->rxfull_event, CAN_MAILBOX_TO_MASK(1));
+ chEvtBroadcastFlagsI(&canp->rxfull_event, CAN_MAILBOX_TO_MASK(2));
chSysUnlockFromIsr();
}
if ((rf1r & CAN_RF1R_FOVR1) > 0) {

Discussion

    • summary: CAN broadcast typo --> STM32 CAN broadcast typo
    • assigned_to: nobody --> gdisirio
    • priority: 5 --> 4
    • milestone: --> trunk
    • status: open --> closed-fixed
     
  • Fixed in repository.