Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

(no subject)

Page 1.0 of 1.14
  • Contains patch + raw check files (with and without folders path saving)

     
  • Oliver Burn
    Oliver Burn
    2012-04-16

    Does the ImportControl check
    (http://checkstyle.sourceforge.net/config_imports.html#ImportControl) not
    already meet these requirements?

    If not, please give a concrete example of where it does not.

     

  • Anonymous
    2012-10-11

    You are right ImportControl is more powerfull from configuration point of view, we are missed it.

     

  • Anonymous
    2012-10-11

    please close issue as "want fix"

     
  • Roman Ivanov
    Roman Ivanov
    2012-10-16

    It is a bit different and more general than ImportControl. It is beneficial in case you need assign more general(less strict) rules for import controll.

    Example for import-control.xml:
    \<import-control pkg=".+.tools..+">
    \<disallow pkg="antlr"/>
    \</import-control>

    ~/java/hg-cs/checkstyle$ mvn install
    ...
    [ERROR] around Ant part ...<ant antfile="ant-phase-verify.xml"/>... @ 7:40 in /home/rivanov/java/hg-cs/checkstyle/target/antrun/build-main.xml: InvocationTargetException: unable to parse file:/home/rivanov/java/hg-cs/checkstyle/import-control.xml - Attribute value ".+.tools..+" of type NMTOKEN must be a name token.

    In example(see description) that we try manage is desire to disallow usage of classes from "ui" packages in all(no limitation to names) classes inside "dao" package. And keeping configuration in the same place as othe is also beneficial in comparison to separate file.

    It will good if ImportControl will support our usecases. To try our check please take a look: http://sevntu-checkstyle.github.com/sevntu.checkstyle/

     
    Last edit: Roman Ivanov 2012-10-16
  • Oliver Burn
    Oliver Burn
    2012-10-17

    • status: pending --> wont-fix
    • milestone: --> Unstable_(example)
     
  • Roman Ivanov
    Roman Ivanov
    2012-10-17

    :) not only me do not like single package configuration - https://sourceforge.net/p/checkstyle/patches/112/, is it time to consider this idea again ?

     
    Last edit: Roman Ivanov 2012-10-17