Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#240 Allow additional URL schemes for SuppressionFilter configuration loading.

Unstable_(example)
closed
nobody
None
1
2013-11-17
2013-07-17
Anonymous
No

Since release 5.6 it is possible to supple http and https URLs for suppression filter configuration.
Attached patch enhances this to allow all URL schemes. (the code is similar to resolution algorithm used in com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(String, PropertyResolver, boolean))

1 Attachments

Discussion

  •     catch (final FileNotFoundException e) {
            if (aFilename.matches("^https?://.+")) {
    
    1. There should be no logic based on Exception handling.
    2. I don`t see any 'Additional URL schemes' except https in your code (http://en.wikipedia.org/wiki/URI_scheme).

    Please, correct me, if I am wrong.

     
  • Closed as author did not respond with further explanation and I cannot contact to him because of request anonymity.

    2Author: if you are still interested, please share you patch as pull request to our new GitHub repo (https://github.com/checkstyle/checkstyle).

     
    • status: open --> closed