#179 Ban usage of platform default encoding using bcel

Unstable_(example)
wont-fix
nobody
None
1
2013-11-17
2010-07-02
No

This patch implements feature request 1952645 [1] using bcel, building on patch 2788019 [2].
It also provides an abstract base class suitable to ban arbitrary other methods as well.

[1] https://sourceforge.net/tracker/?func=detail&aid=1952645&group_id=29721&atid=397081
[2] https://sourceforge.net/tracker/?func=detail&aid=2788019&group_id=29721&atid=397080

Discussion

  • Line numbers patch version 1

     
  • Updated the patch so it prints line numbers as well. The general line number patch might be useful for other BCEL patches as well.

     
  • Currently I don't see the reason to integrate any bytecode analysis tools (including bcel) into Checkstyle. Checkstyle is intended to be a source code analysis tool, otherwise we will lose one of it's main advantages. All bcel-related checks which I am seeing in issues/patches would be better to contribute into FindBugs tool (as FindBugs analyses bytecode from scratch unlike Checkstyle).

    Martin, if you disagree or I am misunderstanding something, please share you ideas as pull request to our new GitHub repo (https://github.com/checkstyle/checkstyle) - so we can discuss them properly.

     
    Last edit: Daniil Yaroslavtsev 2013-11-17
    • status: open --> wont-fix
    • Group: --> Unstable_(example)