Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#108 fix compilation error in contrib/bcel checks

closed
None
5
2012-10-10
2005-10-28
David Dodini
No

The base class for the bcel checkers,
AbstractReferenceCheck, would not compile. It called
Utils.getRE which is no longer supported in the
checkstyle api since checkstyle now uses jdk1.4 regex
classes.

I modified this class to call Utils.getPattern and
changed the usage of this object appropriately. A
better fix would be to remove this dependency
altogether if we want to keep these projects decoupled.
Either that or we could integrate the build and tests
of the contrib code with this project. Let me know and
I am happy to contribute further.

It seems appropriate to submit the changes for this
code to this project. Let me know if not, and I'll find
the appropriate project. I also include an ant script
to build the bcel checks. The buildfile structure may
need changes to fit in with the overall project if you
want to accept it.

Thanks,
David

Discussion

  • David Dodini
    David Dodini
    2005-10-28

     
    Attachments
  • Logged In: YES
    user_id=746148

    This is appropriate place to submit such changes :) and
    thank you for contribution.
    I think this is ok that these checks use public Checkstyle's
    API (I see no reasons to change this)
    As for adding them to official distribution we do not plan
    add them for now (due to lack of support from our side).
    But we open for contributions ;)