In the process of implementing Checkstyle for our
application, we have added several new checks and
Class derived from given class / interface must follow
regexp naming convention.
File must have Copyright or CVS Header in the first
few lines, but is otherwise given latitude in formatting.
A single check can be applied to a variety of files with
Find comparison between null and the result of a
method that actually returns something non-null like the
empty string. A number of engineers were confused by
DOM attributes in this way.
Check that a key to resource bundle lookup actually
Check that every key in a resource bundle is actually
Find switch case that falls through to next case (no
Suppress an audit message by means of a specially
formatted comment in the source near the problem.
Attached is an archive of these addition. No changes
were made to the core, although some things would
have been more straightforward with new core facilities
(like Filter access to FileContents).
I am willing to work to get these integrated into the
main distribution, provided someone inside is committed
to the integration. But I am reluctant to invest time in
a patch on spec, only to have it languish. It is also
easier to maintain in a separate package until an
integration is underway.