#295 Design For Extension check should skip toString()

release_4.1
open
Lars Kühne
5
2012-10-10
2005-02-16
Nicolas Corai
No

... and maybe hashCode() and equals()

An alternative would be to provide a RegExp filter.

Discussion

  • Ken Dobson
    Ken Dobson
    2005-12-02

    Logged In: YES
    user_id=1278266

    There are many places where DesignForExtension has flagged
    errors which I would want to ignore, including
    Object.clone(), flush() and close() on custom Writers,
    Hibernate NamingStrategy implementations, Spring Controller
    and View implementations.

    I have turned off the check because of all these, which is a
    shame because I agree with the principals of the check.

    I suggest that an optional filter could ignore the check if
    it is overriding a method in the super class. This would
    ignore toString(), hashCode(), equals() and all of the
    others which I have mentioned.

    I'd like to see this additional to a RegExp filter.

     
  • Lars Kühne
    Lars Kühne
    2007-02-12

    Logged In: YES
    user_id=401384
    Originator: NO

    1401777 has been marked as a duplicate of this issue.