#3 Patch for bug #2974422, "Invalid enumerant" OpenGL error

closed-accepted
nobody
None
5
2010-03-28
2010-03-27
Alex
No

Here is the patch for fixing the bug in OpenGL rendering code which did not clear the error flag at the end.

The bug is described in detail here:

"Invalid enumerant" when rendering a bezier curve (Win32)
https://sourceforge.net/tracker/?func=detail&aid=2974422&group_id=50475&atid=459847

The patch is against today's git.

Discussion

  • Alex
    Alex
    2010-03-27

    Patch for glrenderer.cpp

     
    Attachments
  • Matthias Baas
    Matthias Baas
    2010-03-28

    • status: open --> closed-accepted
     
  • Matthias Baas
    Matthias Baas
    2010-03-28

    The patch is applied. (I should have caught that one myself. The Python code is called while the C++ loop is running which, of course, means the error flag has to be cleared during the loop and not only at the very end).
    I only did minor changes to the comments. The first line of a doxygen comment should contain the brief description (doxygen can display those separately). The other thing was that the call to glLightModeli() itself was not the problem (that function is defined in OpenGL 1.1), it's rather that the enum value GL_LIGHT_MODEL_COLOR_CONTROL is not defined in v1.1.