Re: [Celestia-developers] Changes to Celestia-Qt4

[Da W. J. <dir...@gm...>]

I also get a crash if I enter jd = 0, leave the calendar date
untouched, and enter time = 0.
Celestia begins to infinitely repeat slotDateTimeChanged(), because
tdb becomes negative and sets the calendar date to < 4713BCE, and
keeps subtracting 1 year until the stack is full. My timezone bias is
-28800 BTW.

DW

On Thu, Feb 28, 2008 at 7:52 AM, vincent wrote:
> Steve Popovich wrote:
>
>  > When I set that date and start to reverse time I can make it back to
>  > Dec.30 -4713 and then Celestia crashes with a segmentation fault.
>
>  Steve, what do you mean by "reverse time"? Do you mean that you change the
>  simulation time using L/K/J or that you set the time in the time dialog
>  using the date edits?
>
>  If it's the first case, then the bug should also appear with a build from
>  the current SVN, and would not be related to the change in the time dialog.
>
>
>  @+
>  Vincent
>
>
>
>
>  >
>  > Chris Laurel <cl...@gm...> wrote: The crash is obviously a bug. But,
>  > 4713 BC is not the same as -4713.
>  > The astronomical dates used by Celestia include a year zero, where as
>  > the BC/AD system does not. Thus, 4713BC = -4712.
>  >
>  > --Chris
>  >
>  > On Wed, Feb 27, 2008 at 11:26 AM, Steve Popovich  wrote:
>  > > Vincent,
>  > > I tried the patch on my Linux box and I get strange results. When I enter
>  > > the date -4713 1, 2, which should be the minimum date allowed by QDate, I
>  > > get -363.73801 as the Julian date. When I press "Set time", Celestia
>  > crashes
>  > > with a segmentation fault. I also get a warning after the build was
>  > complete
>  > > on the terminal. "make: warning:  Clock skew detected.  Your build may be
>  > > incomplete." 4713 BC Jan 2 should be Julian day 0.5 from the Julian
>  > > converter I used. I used QT4.3.3 built with gcc 4.1.2. When I enter -4712,
>  > I
>  > > get the Julian date 1.26199 and the time sets. It seems that you can't go
>  > > below the 4713 BC date allowed by QDate. I'm not sure why there would be
>  > 363
>  > > days difference?
>  > > cartrite
>  > >
>  > >
>  > >
>  > > Chris Laurel  wrote:
>  > >  Vincent,
>  > >
>  > > It works well on my machine . . . I have a couple suggestions:
>  > >
>  > > - It seems to me that 'Set Time' should be the default button. When I
>  > > press enter, it should set the time, not cancel the dialog without
>  > > doing anything.
>  > > - I think that the date control looks a bit cluttered. Maybe the
>  > > dialog could be laid out differently--if it was wider, things wouldn't
>  > > look so crowded. But, I feel like putting all the date elements in a
>  > > single edit box would be better.
>  > >
>  > > --Chris
>  > >
>  > > On Wed, Feb 27, 2008 at 10:33 AM, vincent wrote:
>  > > > In order to definitively get rid of the minimum date issue, I replaced
>  > > > the Qt date edit with a home-made one ;-) I arbitrarily clamped it to
>  > > > years -10000/10000, but we can set larger limits if necessary...
>  > > > I also made the time dialog modeless, as suggested by Da Woon.
>  > > >
>  > > > Here are the modified files for testing:
>  > > > http://vincent.gian.club.fr/celestia/timedialog.zip
>  > > >
>  > > > Please let me know if it works OK on your systems.
>  > > >
>  > > >
>  > > >
>  > > >
>  > > > @+
>  > > > Vincent
>  > > >
>  > > >
>  > > > Selon Chris Laurel :
>  > >
>  > >
>  > > >
>  > > > > On Tue, Feb 26, 2008 at 3:23 AM, vincent wrote:
>  > > > > > Da Woon Jung wrote:
>  > > > > >
>  > > > > > > Time zone and format settings for qt work ok on the Mac. Sorry for
>  > > the
>  > > > > > > delay in testing.
>  > > > > >
>  > > > > > Great ! Thanks for testing the Qt time dialog on Mac, Da Woon.
>  > > > > >
>  > > > > >
>  > > > > >
>  > > > > > > BTW, I noticed some other issues with the qt time dialog:
>  > > > > > > - It shouldn't have to be modal
>  > > > > >
>  > > > > > I agree.
>  > > > > > Chris, is there a specific reason for which you initialy made it
>  > > modal?
>  > > > >
>  > > > > No, there was not. I agree with you and DW that it should be modeless.
>  > > > >
>  > > > > > > - Dates earlier than 1000-01-01 can't be entered
>  > > > > >
>  > > > > > Yes, this is a known issue. Here's what the Qt doc says:
>  > > > > > "The minimum value for QDateTimeEdit is 14 September 1752, and
>  > > > > > 2 January 4713BC for QDate".
>  > > > > >
>  > > > > > So we should be able to set '2 January 4713BC' as the minimum date
>  > > value.
>  > > > > > I'll give it another try...
>  > > > >
>  > > > > I was encountering some strange problems when I changed the allowed
>  > > > > date range for the edit box. That was with Qt 4.3.2, and although I've
>  > > > > since upgraded to 4.3.3, I haven't had a chance to reinvestigate. It's
>  > > > > quite possible we'll have to write our own date edit widget to
>  > > > > accommodate setting dates in the far past or future. However, if we
>  > > > > can in fact set the date back to 4713 BC, then in my opinion this
>  > > > > becomes low priority.
>  > > > >
>  > > > > --Chris
>  > > > >
>  > > > > > > On Sun, Feb 10, 2008 at 6:51 PM, vincent wrote:
>  > > > > > > > I've added the date format and the time zone settings to the time
>  > > > > dialog.
>  > > > > > > > You can test this change using the following files:
>  > > > > > > > http://vincent.gian.club.fr/celestia/timedialog.zip
>  > > > > > > >
>  > > > > > > > The set time dialog now looks like this:
>  > > > > > > > http://vincent.gian.club.fr/celestia/timedialog.jpg
>  > > > > > > >
>  > > > > > > > Please let me know if the Date Format setting works correctly
>  > > under
>  > > > > > > > Mac and Linux. I had to use some ifdef since only two date
>  > formats
>  > > > > > > > are available under Windows. Under Mac and Linux, the three date
>  > > > > > > > formats that Christophe recently added should be available.
>  > > > > > > >
>  > > > > > > >
>  > > > > > > >
>  > > > > > > > @+
>  > > > > > > > Vincent
>  > > > > > > >
>  > > > > > > >
>  > > > > > > > Selon Chris Laurel :
>  > >
>  > > > > > > >
>  > > > > > > > > Thanks for doing this Vincent--I was hoping you'd step in and
>  > > fix
>  > > > > up
>  > > > > > > > > the very minimal Qt4 time dialog. Please check in your patch.
>  > > The
>  > > > > time
>  > > > > > > > > zone changes will be most welcome as well.
>  > > > > > > > >
>  > > > > > > > > I had some trouble getting the Qt4 date edit control to accept
>  > > > > dates
>  > > > > > > > > prior to 1000 CE. The Qt4 docs indicate that it should work
>  > with
>  > > a
>  > > > > > > > > minimum date as early as 2 Jan 4713 BCE, but I had no luck with
>  > > > > that.
>  > > > > > > > > If we can't get it to work with dates at least that early, then
>  > > > > we'll
>  > > > > > > > > need to write our own date edit widget.
>  > > > > > > > >
>  > > > > > > > > --Chris
>  > > > > > > > >
>  > > > > > > > > On Feb 3, 2008 3:59 AM, vincent wrote:
>  > > > > > > > > > I've made the following changes to the Qt4 set time dialog:
>  > > > > > > > > > - Splitted the dateTimeEdit into two separate dateEdit and
>  > > > > timeEdit
>  > > > > > > > > controls
>  > > > > > > > > > - Added a Julian date setting
>  > > > > > > > > >
>  > > > > > > > > > This is how the set time dialog looks like now:
>  > > > > > > > > > http://vincent.gian.club.fr/celestia/jdsetting.jpg
>  > > > > > > > > >
>  > > > > > > > > > And here is the patch file for testing:
>  > > > > > > > > > http://vincent.gian.club.fr/celestia/jdsetting.patch
>  > > > > > > > > >
>  > > > > > > > > > I'm very busy professionnally at the moment. But I should
>  > have
>  > > a
>  > > > > > > chance
>  > > > > > > > > > to work on adding the Time Zone setting during the next
>  > > week-end,
>  > > > > if
>  > > > > > > it's
>  > > > > > > > > > not done already.
>  > > > > > > > > >
>  > > > > > > > > > @+
>  > > > > > > > > > Vincent
>  > > > > >
>  > > > >
>  > > >
>  > > >
>  > > > @+
>  > > > Vincent
>