Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#220 sun, planets and orbits disappear

v1.6
closed-fixed
Chris Laurel
Core (65)
5
2009-02-14
2009-02-02
Selden Ball
No

When Following Earth, and the Milky Way is Selected, turning on Markers makes the Sun, planets and their orbits disappear when viewed from some positions.

This problem is seen in r4624. It is seen as far back as r4495. (I can't test earlier svn versions.)

This problem is not seen in v1.5.1
This problem is not seen in r4624 if "Label Planets" is enabled.

This URL demonstrates the problem. It takes you to a viewpoint just outside the solar system, with markers disabled. When markers are enabled (type a ctrl-K) the solar system disappears. If you move the viewpoint somewhat closer to the solar system, the solar system does not disappear when markers are enabled.

Note also that the "Selected" marker is not being drawn, presumably because the viewpoint is inside the Milky Way.

cel://Follow/Sol:Earth/2009-02-02T16:10:02.15367?x=AABDCv49SbkM&y=AAC1INGARF0W&z=AACAADUWp54Z/////////w&ow=0.0330265&ox=0.118506&oy=-0.991396&oz=-0.0447087&select=Milky Way&fov=34.7467&ts=1&ltd=0&p=0&rf=3970999&lm=17940&tsrc=0&ver=3

Discussion

  • Chris Laurel
    Chris Laurel
    2009-02-10

    I'm unable to reproduce the problem on either Windows or Mac versions of Celestia (r4645). I checked the log for changes since r4624 that may have fixed the problem, but nothing seems like a likely candidate. Do you observe the problem when you run Celestia without any add-ons?

     
  • Selden Ball
    Selden Ball
    2009-02-10

    html containing cel url

     
    Attachments
  • Selden Ball
    Selden Ball
    2009-02-10

    I just now rebuilt r4645 from scratch and still see the problem.
    I'm compiling under Windows XP Pro sp3 using VS2005Express and the makerelease script.

    I'll attach the html file I'm using, in case the URL was damaged when I pasted it.
    File Added: sun_milkyway.html

     
  • Selden Ball
    Selden Ball
    2009-02-10

    sorry: I forgot to mention that this is the only addon in extras other than those included in the svn archive (i.e. the shrox models).

     
  • Chris Laurel
    Chris Laurel
    2009-02-14

    Patch for render.cpp and render.h

     
    Attachments
  • Chris Laurel
    Chris Laurel
    2009-02-14

    I was able to reproduce the bug using your html file. I've attached a patch that fixes it.

     
  • Selden Ball
    Selden Ball
    2009-02-14

    This patch does seem to fix the marker/visibility problem.

    However, this patch and the one for the Atmosphere bug fail to apply simultaneously. I'll leave it to you to make sure they both work together.

    I'm closing this bug report.

     
  • Selden Ball
    Selden Ball
    2009-02-14

    • status: open --> closed-fixed