#122 New atmosphere code doesn't work with multiple stars

v1.5
closed-fixed
Chris Laurel
5
2007-12-06
2007-11-16
Chris Laurel
No

The new OGL2.0 atmosphere code doesn't work correctly with multiple stars. The shaders are written for a single light source; when more than one is present, the result is an invalid shader. They should either be modified to handle more light sources, or--as a temporary fix--only the brightest light source should be considered.

It's likely that a multiple light source scattering shader would have to be broken into multiple passes in order to avoid running out of interpolates on pre-GF8/Radeon 2900 series hardware.

Discussion

  • Chris Laurel
    Chris Laurel
    2007-12-06

    • status: open --> open-fixed
     
  • Chris Laurel
    Chris Laurel
    2007-12-06

    Logged In: YES
    user_id=159994
    Originator: YES

    Fix to ignore all but the brightest light source was committed; awaiting verification, then I'll close bug and open a new one for true multiple light source support in v1.6.

     
  • Chris Laurel
    Chris Laurel
    2007-12-06

    Logged In: YES
    user_id=159994
    Originator: YES

    Verified fixed by Martin.

     
  • Chris Laurel
    Chris Laurel
    2007-12-06

    • status: open-fixed --> closed-fixed