Eric,

I will try to extend Java unit test suite in future patches.

Thanks!

On Thu, Jan 31, 2013 at 9:36 AM, Eric M. Ludlam <eric@siege-engine.com> wrote:
On 01/29/2013 07:41 AM, Vladimir Kazanov wrote:
Eric,

I have reformatted/improved the original patch a bit (mostly cosmetic
changes, with one potential bug fixed), and added a fallback value to
the function you mentioned. I knew about the function calculating
relative file names, but it would not make the code cleaner or shorter
anyway.

I used your patch to the java.el file.  It seems fine to me.  It made me realize that I don't have any java based integration tests, and thus couldn't test your change easily.  This seems like a bit of a hole in the test infrastructure.

The C based integration tests in the 'tests' sbuddirectory in the CEDET repository create C projects, uses srecode to create C code, compile it, parse it with Semantic, etc.  I don't know what tools are installed in build bot for CEDET for compiling Java.  We'd need to tune anything we develop to that tool chain.

Thanks!
Eric




--
Yours sincerely,

Vladimir Kazanov
--

С уважением,

Владимир Казанов