Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#668 Ignore the UnusedModifier PMD test

Needs_Review
closed
nobody
PMD (1)
cdk-1.4.x
1
2013-08-07
2013-08-07
Egon Willighagen
No

There was some discussion about this some time ago, and do not remember (convincing) reasons to keep these warnings, so I like to disable these UnusedModifier tests:

http://pmd.sourceforge.net/pmd-5.0.1/rules/java/unusedcode.html#UnusedModifier

They now cloud the statistics, and it's never been a CDK policy yet to comply to these habits. E.g. it would remove all these:

http://pele.farmbio.uu.se/nightly-jcp/pmd-unused/render.html

Consider this patch as a force to resolve the discussion.

1 Attachments

Discussion

  • John May
    John May
    2013-08-07

    • status: open --> closed
     
  • John May
    John May
    2013-08-07

    Applied and pushed.