#635 Fixed incorrect method call

Accepted
closed
nobody
master
1
2013-06-05
2013-05-15
John May
No

When using Vector, one can use Vector.set(int, Obj) when the 'slot' is empty. This does not work in List. I noticed when testing FiguerasSSSRFinder against the new cycle code that when FiguerasSSSRFinder was converted from using Vector to use List this was not changed and did not work at all. This patch removes the use of set().

Also will try and write some tests for FiguerasSSSRFinder at some point.

J

1 Attachments

Discussion

  • John May
    John May
    2013-05-15

    • labels: --> sssr, ring, ringsearch
     
  • Should this not go into cdk-1.4.x too?

     
  • John May
    John May
    2013-06-04

    No, that still uses Vector.

     
    • Got it.

       
    • status: open --> closed
    • Group: Needs_Review --> Accepted
     
  • Looks good; applied and pushed.

    And I agree that this class really needs unit testing... that way, we may not have missed this regression in the first place :(