Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#631 Fix for the atom type matcher testing stack, bug #1299

Accepted
closed
nobody
None
master
1
2013-05-07
2013-05-06
Egon Willighagen
No

This patch updates the stack to use @AfterClass for counting the tested atom types, rather than relying on the last method in the source code to be called last. This fixes the "regression" introduced by updating the JUnit stack which no longer keeps the test method order.

Two additional patches fixes two problems exposed by this fix:

  1. incorrect casting to cdk.Atom
  2. a fix in counting the tested atoms, and in particular if types are being tested which are not defined in the ontology
1 Attachments

Discussion

  • John May
    John May
    2013-05-07

    @cdk.module test-core
    

    is missing from the new interface, I'm going to go ahead and add this.

     
  • John May
    John May
    2013-05-07

    compiles and no new test fails, applied and pushed

     
  • John May
    John May
    2013-05-07

    • status: open --> closed
    • Group: Needs_Review --> Accepted