#584 Second half of the group module/package

Accepted
closed
nobody
None
master
5
2012-12-02
2012-11-20
No

There are 4 patch files in the zip, but the first three are minor additions and a bugfix to the existing partition class.

The large patch contains all the new classes, test cases, and additions to depends files. Test-module runs without errors or fails. These patches are also available from this branch https://github.com/gilleain/cdk/tree/group

Also, there is a post explaining a bit about the module on my blog, although I won't spam the link here.

1 Attachments

Discussion

<< < 1 2 (Page 2 of 2)
  • Argh. Dammit, yes : the whole point of the javadoc comment is that you can either call "class.getX(Y)" or "class.refine(Y); super.getX()" so that #getGroup should be a link to the superclass method.

    Anyway, thanks for the reviews!

     
  • Sorry, re-reading my last comment it may not have been clear. You are correct; it's my mistake. Could make a tiny patch for it.

     
  • John May
    John May
    2012-11-29

    Okay done

     
  • Applied and pushed.

    Added a missing dep in test-group.libdepends.

     
    • status: open --> closed
     
<< < 1 2 (Page 2 of 2)