Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#575 [bug:1278] AtomContainerPermutatorpatch and cleanup

Accepted
closed
nobody
graph (5)
cdk-1.4.x
1
2013-03-26
2012-11-09
John May
No
  • Fixed a bug where a cast to implementation was expected.
  • Reword documentation - this is a really useful class
  • Reordered implementation so it read clearer and added logging method for exception

https://github.com/johnmay/cdk/commits/cdk-1.4.x+

Related

Patches: #575

Discussion

  • For the URL, please use @cdk.cite (see GitHub). The other two look good to me.

     
    • milestone: Needs_Review --> Needs_Revision
     
  • John May
    John May
    2012-12-12

    missing comment again?

     
  • John May
    John May
    2013-03-21

    • summary: [bug:1278] patch and cleanup --> [bug:1278] AtomContainerPermutatorpatch and cleanup
     
  • Yes, you're correct. Doing the documentation patches now. That leaves the missing unit testing...

     
  • OK, and these two documentation patches don't apply to master :(

     
  • John May
    John May
    2013-03-23

    Yes Gilleain has rewritten the entire class. Will be good to be back on a single branch :).

     
    Last edit: John May 2013-03-23
  • John May
    John May
    2013-03-26

    applied and pushed by Egon - also these classes were changed in master by gilleain

     
  • John May
    John May
    2013-03-26

    • status: open --> closed
    • milestone: Needs_Revision --> Accepted