This patch provides documentation an additional unit test for Stephan's N Planar 3 atom type patch (#3554480) to ensure explicit hydrogens do not affect the perception.
Looks good. One small type; please fix then. Then I'll check for compiling and regressions:
Oh, actually, did I ever tell you about @cdk.inchi ? You can add that JavaDoc to test methods to indicate what molecules is being tested... best to use an InChI with the FixedH layer...
Okay have updated the patch. I decided to add comments in the actual method body and restructure the conditionals to make it clearer what was actually happening. Have also included the @cdk.inchi.
I welcome an later patch for this:
I did not spot that earlier :(
Sorry I'm not following?
Oh. just that assert takes (expected, actual) rather than the above.
Best practise is actually to use assertThat :)
Ah, yes, that made it into JUnit now...