Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#390 Patch that moves ArrowElement from CDK-JCP to renderbasic

Needs_Review
closed
Rajarshi Guha
cdk-1.4.x (181)
5
2012-10-28
2011-07-18
Egon Willighagen
No

Fixing rendering of reaction schemes. The latter is in renderextra, and the arrow element is just an underlying drawing element.

Discussion

  • Yes, this looks fine. It's not much 'extra' to have some more Rendering Element classes, so I don't see why it shouldn't be in renderer basic.

    Of course, the question arises : couldn't arrows be drawn with line elements? :)

     
  • The main purpose of renderbasic / renderX is to be able to remove large dependencies, such as the IsotopeFactory, or all ChemModel level classes...

    Rajarshi, could you please have a brief look at it too? Then it had two reviews, and it's good to go.

     
  • Making an release manager call here. I want this fix in, and it is approved by one reviewer, so I'll argue that is a bug fix (it is) and that a unit test is excused, because the exception cannot be reproduced until renderextra is ported into the CDK.