Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#268 Patch to solve formal charge matching

Needs_Review
closed
nobody
cdk-1.2.x (46)
9
2012-10-28
2010-09-08
Egon Willighagen
No

Discussion

  • Instead of
    atom.getFormalCharge().intValue() != type.getFormalCharge().intValue()
    it would be better to use
    !atom.getFormalCharge().equals(type.getFormalCharge()
    for checking Integer equality.

     
  • Interesting suggestion... see updated patch.

     
  • Applied to cdk-1.2.x.