Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#148 Error reporting API for IO

closed
nobody
None
5
2012-10-08
2010-02-01
Egon Willighagen
No

Extends the IO API to allow error reporting in relaxed mode, allowing validating editors.

Discussion

  • Rajarshi Guha
    Rajarshi Guha
    2010-02-03

    Patches look OK, applied cleanly, but ant clean dist-all fails

     [echo] Developer Library dependencies defined: ${module.devellibdepends.present}
     [echo] Autogenerated files specified: ${module.autogenerated.present}
    [mkdir] Created dir: /Users/rguha/src/java/cdk/build/src/io
    [mkdir] Created dir: /Users/rguha/src/java/cdk/build/io
     [copy] Copying 79 files to /Users/rguha/src/java/cdk/build/src/io
    [javac] Compiling 79 source files to /Users/rguha/src/java/cdk/build/io
    [javac] /Users/rguha/src/java/cdk/build/src/io/org/openscience/cdk/io/DefaultChemObjectReader.java:45: cannot find symbol
    [javac] symbol  : class IChemObjectReaderErrorHandler
    [javac] location: class org.openscience.cdk.io.DefaultChemObjectReader
    [javac]     protected IChemObjectReaderErrorHandler errorHandler = null;
    [javac]               ^
    [javac] /Users/rguha/src/java/cdk/build/src/io/org/openscience/cdk/io/DefaultChemObjectReader.java:94: cannot find symbol
    [javac] symbol  : class IChemObjectReaderErrorHandler
    [javac] location: class org.openscience.cdk.io.DefaultChemObjectReader
    [javac]     public void setErrorHandler(IChemObjectReaderErrorHandler handler) {
    

    ....

     
  • I cannot confirm... when applying them to master, I can run 'ant clean dist-all test-dist-all' on each of them...

    Can you check:

    $ grep ChemObjectReader build/*.javafiles
    build/io.javafiles:org/openscience/cdk/io/ISimpleChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/IChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/IChemObjectReaderErrorHandler.java
    build/io.javafiles:org/openscience/cdk/io/iterator/IIteratingChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/iterator/event/DefaultEventChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/iterator/event/IEventChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/iterator/DefaultIteratingChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/DefaultChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/random/DefaultRandomAccessChemObjectReader.java
    build/io.javafiles:org/openscience/cdk/io/random/IRandomAccessChemObjectReader.java
    build/test-io.javafiles:org/openscience/cdk/io/SimpleChemObjectReaderTest.java
    build/test-io.javafiles:org/openscience/cdk/io/ChemObjectReaderTest.java

    The output indicates they DefaultChemObjectReader and IChemObjectReaderErrorHandler both are in the io module... can you confirm?

     
  • Rajarshi Guha
    Rajarshi Guha
    2010-02-03

    DefaultChemObjectReader is present in the io module but IChemObjectReaderErrorHandler is not (I just synced up with master)

    guhar@OfficeMac:~/src/cdk [io]$ grep ErrorHandler build/*.javafiles
    build/io.javafiles:org/openscience/cdk/io/cml/CMLErrorHandler.java

     
  • Rajarshi Guha
    Rajarshi Guha
    2010-02-03

    Works fine now. Applied, pushed to master