#113 Extraction of common unit tests for IFingerprinter

Needs_Revision
closed
Rajarshi Guha
None
5
2012-10-08
2009-10-13
Egon Willighagen
No

This patch aimed at master, refactors the unit tests for IFingerprinter implementations, providing the unit tests for a few bugs to all implementations.

Rajarshi, you are most familiar with the IFingerprinter code; can you (as a minimum) review the two patches?

Discussion

  • You will likely notice that a few unit tests are actually failing. This means either the unit test for those bug reports contain bugs, or the IFingerprinter implementation does, IMHO. This needs to be explored separately.

     
  • Rajarshi Guha
    Rajarshi Guha
    2009-10-14

    Patches look good. Applied to master and pushed to GitHub