[Cdk-devel] [ cdk-Bugs-710695 ] Inconsistent get methods in AtomContainer.java

[SourceForge.net <no...@so...>]

Bugs item #710695, was opened at 2003-03-27 13:51
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=120024&aid=710695&group_id=20024

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Kai Hartmann (kaihartmann)
Assigned to: Nobody/Anonymous (nobody)
Summary: Inconsistent get methods in AtomContainer.java

Initial Comment:
Not a real bug, but a little inconsistency concerning
the method names in the AtomContainer class:

getHighestCurrentBondOrder
getMinimumBondOrder

In my opinion, the first method should be named

getMaximumBondOrder

to keep the names easy to remember and consistent.

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2003-03-27 15:28

Message:
Logged In: YES 
user_id=25678

I prefer the getMaximum/MinimumBondOrder naming scheme Kai
suggested.
The getHighestCurrentBondOrder would be deprecated. But
since we don't have officially released a stable release,
what's the use of having deprecated methods?

----------------------------------------------------------------------

Comment By: Christoph Steinbeck (steinbeck)
Date: 2003-03-27 14:53

Message:
Logged In: YES 
user_id=54358

As Kai suggested in a personal communication, the old method
should first be kept but deprecated and a new method with a
better name should be added. 

What do we want to keep? The "current" version or the other? 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=120024&aid=710695&group_id=20024