Re: [Cdk-user] another CDK-JChemPaint patch (renderbasic)

[Rajarshi G. <raj...@gm...>]

I've been browsing the patch on github and one general recommendation
I'd have is to make as much of the classes as possible into package
private? Currently, most (all?) of the classes are public - but as far
as I can tell are targeted to the rendering machinery. From the users
PoV, I think the public API can be very minimal.

On Sun, May 29, 2011 at 4:36 PM, Egon Willighagen
<ego...@gm...> wrote:
> Hi all,
>
> I have just submitted another piece of the CDK-JChemPaint code as
> patch: the renderbasic module. This module contains all the code to
> visualize molecules:
>
> https://sourceforge.net/tracker/?func=detail&aid=3309071&group_id=20024&atid=320024
>
> This patch report has all the detail about the patch, and it's current
> state, etc.
>
> I kindly like to ask people to review the code. As many developers
> have been involved from the more regular CDK contributors, and in
> particularly from the labs in Uppsala and at the EBI, it comes down to
> others to independently review the patch.
>
> To review the code, please use the following approach:
>
> 1. find the full, collapsed patch:
> https://github.com/egonw/cdk/commit/f4af0e9527f5c0a7a4606a0957c7a20a64127a9c
> 2. read this blog post on how to add comments to such a patch on
> GitHub: http://chem-bla-ics.blogspot.com/2010/05/how-to-use-github-for-cdkbioclipse-code.html
> 3. use that approach to add comments to the page given in 1.
> 4. reply to this email, indicating you left comments, and indicate
> what you think of the state of the code
>
> Any reviewing will be much appreciated!
>
> Egon
>
> --
> Dr E.L. Willighagen
> Postdoctoral Researcher
> Institutet för miljömedicin
> Karolinska Institutet (http://ki.se/imm)
> Homepage: http://egonw.github.com/
> LinkedIn: http://se.linkedin.com/in/egonw
> Blog: http://chem-bla-ics.blogspot.com/
> PubList: http://www.citeulike.org/user/egonw/tag/papers
>
> ------------------------------------------------------------------------------
> vRanger cuts backup time in half-while increasing security.
> With the market-leading solution for virtual backup and recovery,
> you get blazing-fast, flexible, and affordable data protection.
> Download your free trial now.
> http://p.sf.net/sfu/quest-d2dcopy1
> _______________________________________________
> Cdk-user mailing list
> Cdk...@li...
> https://lists.sourceforge.net/lists/listinfo/cdk-user
>



-- 
Rajarshi Guha
NIH Chemical Genomics Center