From: SourceForge.net <no...@so...> - 2011-09-17 08:40:20
|
Patches item #3410770, was opened at 2011-09-17 10:40 Message generated for change (Tracker Item Submitted) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3410770&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Bug fix for ReactionScheme cloning of properties Initial Comment: Fixing a four failing unit tests for the four IReactionScheme implementations now reported by Nightly, such as: Testcase: testClone_Properties2(org.openscience.cdk.ReactionSchemeTest): FAILED expected:<1> but was:<0> junit.framework.AssertionFailedError: expected:<1> but was:<0> at org.openscience.cdk.interfaces.AbstractChemObjectTest.testClone_Properties2(AbstractChemObjectTest.java:194) One review is enough, with unit tests being present, and fixing a bug. The actual test in AbstractChemObjectTest is a bit hard to understand, but is used by all IChemObject child interface implementation, such as AtomTest, etc, etc. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3410770&group_id=20024 |
From: SourceForge.net <no...@so...> - 2011-09-17 12:28:03
|
Patches item #3410770, was opened at 2011-09-17 08:40 Message generated for change (Comment added) made by gilleain You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3410770&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x >Group: Accepted Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) >Assigned to: Egon Willighagen (egonw) Summary: Bug fix for ReactionScheme cloning of properties Initial Comment: Fixing a four failing unit tests for the four IReactionScheme implementations now reported by Nightly, such as: Testcase: testClone_Properties2(org.openscience.cdk.ReactionSchemeTest): FAILED expected:<1> but was:<0> junit.framework.AssertionFailedError: expected:<1> but was:<0> at org.openscience.cdk.interfaces.AbstractChemObjectTest.testClone_Properties2(AbstractChemObjectTest.java:194) One review is enough, with unit tests being present, and fixing a bug. The actual test in AbstractChemObjectTest is a bit hard to understand, but is used by all IChemObject child interface implementation, such as AtomTest, etc, etc. ---------------------------------------------------------------------- >Comment By: gilleain maclean torrance (gilleain) Date: 2011-09-17 12:28 Message: Looks fine. Tests run, and clone props test now passes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3410770&group_id=20024 |
From: SourceForge.net <no...@so...> - 2011-09-18 05:51:24
|
Patches item #3410770, was opened at 2011-09-17 10:40 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3410770&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x Group: Accepted >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Egon Willighagen (egonw) Summary: Bug fix for ReactionScheme cloning of properties Initial Comment: Fixing a four failing unit tests for the four IReactionScheme implementations now reported by Nightly, such as: Testcase: testClone_Properties2(org.openscience.cdk.ReactionSchemeTest): FAILED expected:<1> but was:<0> junit.framework.AssertionFailedError: expected:<1> but was:<0> at org.openscience.cdk.interfaces.AbstractChemObjectTest.testClone_Properties2(AbstractChemObjectTest.java:194) One review is enough, with unit tests being present, and fixing a bug. The actual test in AbstractChemObjectTest is a bit hard to understand, but is used by all IChemObject child interface implementation, such as AtomTest, etc, etc. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2011-09-18 07:51 Message: Pushed to cdk-1.4.x. ---------------------------------------------------------------------- Comment By: gilleain maclean torrance (gilleain) Date: 2011-09-17 14:28 Message: Looks fine. Tests run, and clone props test now passes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3410770&group_id=20024 |