From: SourceForge.net <no...@so...> - 2010-05-23 07:30:57
|
Patches item #3005890, was opened at 2010-05-23 09:30 Message generated for change (Tracker Item Submitted) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Standard InChI support Initial Comment: I made the choice of setting up a separate module, allowing people downstream to choose InChI or Standard InChI support. For this, I copied the existing code, and made only very few code changes. I am the original author, and have refrained from code clean up at this stage. If you find places for code improvement, please file as bug report, so that it can be fixed in both the inchi and sinchi module. One such comment would be the incomplete unit testing: 3005889 inchi module test suite incomplete Patch available from: http://github.com/egonw/cdk/tree/151-jniinchi Commit message: Copied the inchi module into the sinchi module, providing Standard InChI support with JNI-InChI 0.7. * provides Standard InChI generations * separate module to also provide InChI 1 support * based on JNI-InChI 0.7 + FreeBSD patch * now also works on 64bit OS/X Thanx to Nina Jeliazkova! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-10-16 20:44:31
|
Patches item #3005890, was opened at 2010-05-23 03:30 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Standard InChI support Initial Comment: I made the choice of setting up a separate module, allowing people downstream to choose InChI or Standard InChI support. For this, I copied the existing code, and made only very few code changes. I am the original author, and have refrained from code clean up at this stage. If you find places for code improvement, please file as bug report, so that it can be fixed in both the inchi and sinchi module. One such comment would be the incomplete unit testing: 3005889 inchi module test suite incomplete Patch available from: http://github.com/egonw/cdk/tree/151-jniinchi Commit message: Copied the inchi module into the sinchi module, providing Standard InChI support with JNI-InChI 0.7. * provides Standard InChI generations * separate module to also provide InChI 1 support * based on JNI-InChI 0.7 + FreeBSD patch * now also works on 64bit OS/X Thanx to Nina Jeliazkova! ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-10-16 16:44 Message: could you rebase this against the latest master? it'd be easier to review ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-10-17 11:23:14
|
Patches item #3005890, was opened at 2010-05-23 09:30 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: cdk-1.4.x Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Standard InChI support Initial Comment: I made the choice of setting up a separate module, allowing people downstream to choose InChI or Standard InChI support. For this, I copied the existing code, and made only very few code changes. I am the original author, and have refrained from code clean up at this stage. If you find places for code improvement, please file as bug report, so that it can be fixed in both the inchi and sinchi module. One such comment would be the incomplete unit testing: 3005889 inchi module test suite incomplete Patch available from: http://github.com/egonw/cdk/tree/151-jniinchi Commit message: Copied the inchi module into the sinchi module, providing Standard InChI support with JNI-InChI 0.7. * provides Standard InChI generations * separate module to also provide InChI 1 support * based on JNI-InChI 0.7 + FreeBSD patch * now also works on 64bit OS/X Thanx to Nina Jeliazkova! ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-10-17 13:23 Message: Rebased for cdk-1.4.x and updated patch available at: http://github.com/egonw/cdk/tree/151-jniinchi ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-10-16 22:44 Message: could you rebase this against the latest master? it'd be easier to review ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-10-17 14:00:35
|
Patches item #3005890, was opened at 2010-05-23 03:30 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cdk-1.4.x >Group: Accepted >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Standard InChI support Initial Comment: I made the choice of setting up a separate module, allowing people downstream to choose InChI or Standard InChI support. For this, I copied the existing code, and made only very few code changes. I am the original author, and have refrained from code clean up at this stage. If you find places for code improvement, please file as bug report, so that it can be fixed in both the inchi and sinchi module. One such comment would be the incomplete unit testing: 3005889 inchi module test suite incomplete Patch available from: http://github.com/egonw/cdk/tree/151-jniinchi Commit message: Copied the inchi module into the sinchi module, providing Standard InChI support with JNI-InChI 0.7. * provides Standard InChI generations * separate module to also provide InChI 1 support * based on JNI-InChI 0.7 + FreeBSD patch * now also works on 64bit OS/X Thanx to Nina Jeliazkova! ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-10-17 10:00 Message: Applied and pushed ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-10-17 07:23 Message: Rebased for cdk-1.4.x and updated patch available at: http://github.com/egonw/cdk/tree/151-jniinchi ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2010-10-16 16:44 Message: could you rebase this against the latest master? it'd be easier to review ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3005890&group_id=20024 |