From: Jonathan Alvarsson <jonathan.alvarsson@gm...> - 2012-07-31 08:41:21
Awesome, great work!
On Sat, Jul 28, 2012 at 2:38 PM, Egon Willighagen
> Hi Jonathan...
> it's summer time, so I have a bit more time to work on the CDK :)
> I merged you fingerprinter work into master... triggered by the recent
> FP discussions...
> It looks good; there are merely two regressions:
> The second is caused by a merge artifact by me, where one method had
> TestMethod annotation, and since it had not no such annotation, I
> blindly (stupidly) copied that into your patches... But since you
> actually implement that method now, the tests fails as no exception is
> thrown... I'll fix that.
> The first has to do with a missing unit test:
> Dr E.L. Willighagen
> Postdoctoral Researcher
> Department of Bioinformatics - BiGCaT
> Maastricht University (http://www.bigcat.unimaas.nl/)
> Homepage: http://egonw.github.com/
> LinkedIn: http://se.linkedin.com/in/egonw
> Blog: http://chem-bla-ics.blogspot.com/
> PubList: http://www.citeulike.org/user/egonw/tag/papers