Yeah it's always hard to remember to not put those in, it does look much nice without the modifiers but I'm not too bothered. I guess it wouldn't be too hard to remove the existing ones?

Reminds me of something mentioned on the Java posse recently: http://graphics-geek.blogspot.co.uk/2013/03/for-api-nerds-interfaces-and-inner.html

On 3 May 2013, at 09:32, Egon Willighagen <egon.willighagen@gmail.com> wrote:

Hi all,

I was doing some spring clean up. Master is really getting into shape,
and it seems it's well on track to become the next "stable" in
reasonable time.

I am trying to get some more JavaDoc and PMD clean up done, and get
them between 6k and 9k respectively:

http://pele.farmbio.uu.se/supernightly/

I then noted that we have a lot of warnings about unused code in the
interfaces module:

http://pele.farmbio.uu.se/nightly/pmd-unused/interfaces.html

What is your opinion? Should PMD warn us about it, and should we thus
try to fix these things? Now, I personally do not mind have explicit
modifiers. Therefore, I prefer to disable this PMD test for the CDK.

Please let me know. The fewer false positives (if you agree explicit
modifiers are OK), the easier it is to find other things to fix...

Egon

--
Dr E.L. Willighagen
Postdoctoral Researcher
Department of Bioinformatics - BiGCaT
Maastricht University (http://www.bigcat.unimaas.nl/)
Homepage: http://egonw.github.com/
LinkedIn: http://se.linkedin.com/in/egonw
Blog: http://chem-bla-ics.blogspot.com/
PubList: http://www.citeulike.org/user/egonw/tag/papers

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Cdk-devel mailing list
Cdk-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdk-devel