Hi Tomas,

In this case, I could submit the patch also to the 1.4 branch, because the old code still remains. Is that correct?

I see no problem with that - don't submit two patches though. If you submit to master we should be able to backport it to cdk-1.4.x.

Could you please give me a quick advice, what is the current preferred way of submitting patches? Should I create a pull request on github? Or create a ticket on sourceforge?

Create a patch tracker on sourceforge then you can either attach a ".patch" file using 'git format-patch' or fork github.com/egonw/cdk/ then branch against your now forked master giving a meaningful branch name. I'd imagine this would be multiple commits so I would go down the fork and branch.

Thanks,
John

On 1 Nov 2012, at 00:50, Tomas Pluskal <pluskal@oist.jp> wrote:

Hi John,


Looks great - will wait for Miguel to give his opinions on the method but on the implementation side I can answer a few things.

Seem like Miguel has no opinion.. I will proceed with creating a new class for this. 

It might be worth deprecating the existing class and writing a clean implementation. We have this with SSSR, there is an old deprecated version and a newer implementation. This will then serve as a) and archive of the algorithm and b) won't break any existing code that is using it.

I like this idea. 

In this case, I could submit the patch also to the 1.4 branch, because the old code still remains. Is that correct?

Could you please give me a quick advice, what is the current preferred way of submitting patches? Should I create a pull request on github? Or create a ticket on sourceforge?

Best regards,

Tomas


===============================================
Tomáš Pluskal
G0 Cell Unit, Okinawa Institute of Science and Technology Graduate University
1919-1 Tancha, Onna-son, Okinawa 904-0495, Japan
WWW: https://groups.oist.jp/g0
TEL: +81-98-966-8684
Fax: +81-98-966-2890

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct_______________________________________________
Cdk-devel mailing list
Cdk-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdk-devel