Yes,

The generator wants to be immutable/stateless so know one has to lock or synchronise. However accepting users classes as input means you can't possible guarantee that. The default encoders are immutable enums and any additional ones are expected to be an anonymous classes, lambda in jdk 8. This was an attempt to warn if there could be a problem, that should go to the debug logger though. Will add an update for that.  

https://github.com/johnmay/cdk/blob/master/src/main/org/openscience/cdk/hash/HashGeneratorMaker.java#L270

J

On 1 May 2013, at 10:07, Egon Willighagen <egon.willighagen@gmail.com> wrote:

John,

what do these message come from?

Testsuite: org.openscience.cdk.modulesuites.MhashTests
Tests run: 165, Failures: 2, Errors: 0, Time elapsed: 3.694 sec

------------- Standard Error -----------------
AtomEncoder had fields but should be stateless
AtomEncoder had fields but should be stateless
AtomEncoder had fields but should be stateless
AtomEncoder had fields but should be stateless
------------- ---------------- ---------------

Are those notes to yourself? Did JUnit produce those?

Egon

--
Dr E.L. Willighagen
Postdoctoral Researcher
Department of Bioinformatics - BiGCaT
Maastricht University (http://www.bigcat.unimaas.nl/)
Homepage: http://egonw.github.com/
LinkedIn: http://se.linkedin.com/in/egonw
Blog: http://chem-bla-ics.blogspot.com/
PubList: http://www.citeulike.org/user/egonw/tag/papers

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Cdk-devel mailing list
Cdk-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdk-devel