#764 CML reading of aromaticity info of bonds is broken

cdk-1.0.x
closed
nobody
9
2012-11-03
2008-11-16
Egon Willighagen
No

Effectively, all bonds are read as being aromatic.

See commits 13122, 13124 for CDK 1.2.x. The fix (13124) is:

diff --git a/src/main/org/openscience/cdk/io/cml/CMLCoreModule.java b/src/main/org/openscience/cdk/io/cml/CMLCoreModule.java
index fb53e59..5dc51c5 100644
--- a/src/main/org/openscience/cdk/io/cml/CMLCoreModule.java
+++ b/src/main/org/openscience/cdk/io/cml/CMLCoreModule.java
@@ -663,10 +663,10 @@ public class CMLCoreModule implements ICMLModule {
if ("bond".equals(name)) {
if (!stereoGiven)
bondStereo.add("");
- if (bondStereo.size() > bondDictRefs.size())
+ if (bondCounter > bondDictRefs.size())
bondDictRefs.add(null);
- if (bondAromaticity.size() > bondDictRefs.size())
- bondAromaticity.add(null);
+ if (bondCounter > bondAromaticity.size())
+ bondAromaticity.add(null);
} else if ("atom".equals(name)) {
if (atomCounter > eltitles.size()) {
eltitles.add(null);

Discussion