#1284 Regressions(?) in SimpleCycleBasisTest

cdk-1.4.x
closed
nobody
None
1
2012-12-12
2012-12-12
Egon Willighagen
No

Not sure how long these have been failing, because the tests have not been run ever since we moved to JUnit4 :(

Discussion

    • status: open --> closed
     
  • OK, the problem was with the moment the test graph got set. In JUnit4 the default test graph gets overwritten at some point (or so it seems), so the solution was to reset the test graph before each test method was called, by using @Before instead of @BeforeClass ...

     
  • John May
    John May
    2012-12-12

    okay that makes sense

     
  • John May
    John May
    2012-12-12

    Possibly @BeforeTest would be even safer but if it works with @BeforeClass then it's probably fine..?

     
  • @BeforeTest == @Before

    @BeforeClass did not work; that's what it was with the fails. Several tests change the graph, so the original code depended on the order in which the tests were run, I think.