Re: [Ccnet-devel] Three patches for CCTray

[Daniel P. <dan...@gm...>]

Hi Thomas,

I've reviewed all the patches and they all look good. You got lucky in the
sense that they're issues that can't really be unit tested. I've committed
the code. Thanks for your help on this.

-Dan Piessens


On 9/26/06, Thomas Freudenberg <in...@th...> wrote:
>
> Ooops, the subject was wrong. Only two of the issues relate to CCTray.
> Of course the third patch applies to the web dashboard.
>
> Regards,
> Thomas
>
> On 9/27/06, Thomas Freudenberg <in...@th...> wrote:
> > Hi all,
> >
> > there are some issues which really annoy me. However, instead of
> > whining I fixed them and attached the patch files to existing issues
> > which I think match the problems most. Maybe some of you don't want
> > wait until the patches are commited to the source tree, so here they
> > are:
> >
> > 1. The main form is visible after start-up (though minimized). My
> > patch persists the current state along with the window's position and
> > size. If the form is not shown, and you close CCTray and start it
> > again, the main form will now be hidden automatically. [1]
> >
> > 2. If the explorer crashes (or is killed intentionally), the
> > notification icon won't be recreated. [2]
> >
> > 3. You cannot run the web dashboard at the root of the web server. [3]
> >
> > Best regards,
> > Thomas
> >
> >
> > [1] http://jira.public.thoughtworks.org/browse/CCNET-680
> > [2] http://jira.public.thoughtworks.org/browse/CCNET-693
> > [3] http://jira.public.thoughtworks.org/browse/CCNET-659
> >
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ccnet-devel mailing list
> Ccn...@li...
> https://lists.sourceforge.net/lists/listinfo/ccnet-devel
>