Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#18 grib display may not work if no pressure record loaded

closed-fixed
Yoda044
None
8
2008-07-15
2008-07-14
cyrille rosay
No

Yoda,
during a code review, I've seen this sequence:
for(int j = 0; j < recordLight.length; j++){
GribRecordPDS pds = recordLight[j].getPDS();
String type = pds.getType();
String sDate = spf.format(pds.getLocalForecastTime().getTime());

if( type.equals("prmsl")){
listOfTime[nbPressure++] = sDate;
pressureRecordLight.put(sDate, j);
}else if( type.equals("ugrd")){
uwindRecordLight.put(sDate, j);
}
}

My concern is that listOfTime is filled only when record type are "prmsl" (pressure medium sea level".
knowing that with ugrib.exe you can load pressure, wind or rain information or any of these independently, it appears that we could have an empty listOfTime if the user decide to download only wind weather information (or rain)...

Discussion

  • cyrille rosay
    cyrille rosay
    2008-07-14

    • priority: 5 --> 8
    • assigned_to: nobody --> yoda044
     
  • Yoda044
    Yoda044
    2008-07-15

    • status: open --> open-accepted
     
  • Yoda044
    Yoda044
    2008-07-15

    Logged In: YES
    user_id=1517854
    Originator: NO

    i would rather remplace it by a set

     
  • Yoda044
    Yoda044
    2008-07-15

    Logged In: YES
    user_id=1517854
    Originator: NO

    Correct with the commit of GribParser, v1.7

     
  • Yoda044
    Yoda044
    2008-07-15

    • status: open-accepted --> closed-fixed