Menu

#5 post/comment notification: mail header broken

closed
nobody
None
5
2003-10-17
2003-10-13
No

When a comment is posted to a blog and the admin
enabled the notification, the author of a post is
notified by email about new comments. The mail that
gets sent has a broken mail header. This is a result of
a "tweak" used to add the wordpress version as
X-Mailer-header by appending the additional line to $from.

The "From: ..." and the "X-Mailer: ..." part of $from
are "divided" with "\r\n", where a simple "\n" would be
correct. Fixing this should be trivial. If necessary I
provide a patch in order to ease up commiting the fix
to CVS.

Discussion

  • Mike Little

    Mike Little - 2003-10-17

    Logged In: YES
    user_id=23371

    No, according to RFC 822
    (ftp://ftp.demon.co.uk/pub/doc/rfc/rfc822.txt) section
    3.1.2, header fields should be terminated with CRLF

    Mike

     
  • Mike Little

    Mike Little - 2003-10-17
    • status: open --> closed
     
  • Michael Renzmann

    Logged In: YES
    user_id=1045

    First of all: what I wrote there about a "hack" is trash, of
    course. That's the normal way of adding additional headers
    to e-mails.

    Second: You are right with RFC 822. Headers are expected to
    be terminated with CRLF (\r\n).

    But the problem still exists. After some tests it seems that
    this is an issue related to my Exim installation. Just
    wanted to let you know in case someone else is coming across
    this...

     

Log in to post a comment.