#55 Simple Patch to hide observers on currentplayers.php

closed-rejected
nobody
None
3
2011-07-31
2007-12-15
Kscript
No

As said above, this patch hides observers on currentplayers.php by default, with a link to enable them. This patch does not include advanced features (like persistence), and I do not claim that it works. All information is entered in the URL string.

(NOTE: I exported the SVN under the "webstats" directory)

--F687/s

Discussion

  • Kscript
    Kscript
    2007-12-15

    The patch file.

     
    Attachments
  • Joshua Bodine
    Joshua Bodine
    2007-12-20

    Logged In: YES
    user_id=1417147
    Originator: NO

    First of all, if you're going to bother submitting a patch to the project, we would much appreciate it if you confirm that it works before doing so. It makes our job much easier.

    Viewing observers along with the rest of the players seems to be the preferred approach to me. If the number of observers gets to be very large relative to the number of players, perhaps an option to disable the inclusion of observers would be in order. However, I personally don't see a need right now to make this the default behavior.

    If you need an actual list of current players (excluding observers) for parsing, there are better ways. If you're interested in just the users who are actually playing, shouldn't ignoring the others be sufficient?

     
  • Joshua Bodine
    Joshua Bodine
    2008-03-15

    • priority: 5 --> 3
    • status: open --> closed-rejected
     
  • Joshua Bodine
    Joshua Bodine
    2008-03-15

    Logged In: YES
    user_id=1417147
    Originator: NO

    I'm going to go head and close this tracker issue and move it to Rejected Modifications. The patch will remain available for users who are running their own instances of Got Stats? who may want this sort of behavior, but this specific behavior isn't really something we want in the project-run version.

    Splitting up bots and observers into two player sections would be useful, but we don't really have this ability until the current (2.0) protocol and stats retrieval system. We may be revamping our stats site at some point soon, at which time such a subdivision may be implemented.

     
  • Jeff Myers
    Jeff Myers
    2011-07-31

    • status: closed-rejected --> open-rejected
     
  • Jeff Myers
    Jeff Myers
    2011-07-31

    • status: open-rejected --> closed-rejected