#292 Added Sketch to Database and ConstDatabase

Incomplete
open
None
5
2014-08-19
2014-07-29
Anonymous
No

As we discussed yesterday on IRC, I submit this patch

1 Attachments

Discussion

  • Andrei,

    • In ConstDatabase.cpp there is one new-line too many.
    • A simple memcpy isn't enough to copy a rt_sketch_internal.

    Daniel

     
  • BU_GET(rtInternal, rt_sketch_internal);
    memcpy(rtInternal, sketch->Internal(), sizeof(rt_sketch_internal));
    rtInternal = rt_copy_sketch(sketch->Internal());

    Really? You should rethink what every one of these lines does.

    Daniel