#204 Current work on rtgeom.h

Incomplete
closed
Sean Morrison
None
5
2013-07-20
2013-06-25
Isaac Kamga
No

I am working on the include/rtgeom.h file to incorporate the heart primitive . This is what I did today. I will improve on it later .

1 Attachments

Discussion

  • Isaac Kamga
    Isaac Kamga
    2013-06-26

    Today , I included the internal representation of the heart to the rtgeom.h header file by writing the struct rt_hrt_internal structure (the ID_HRT section )

     
    Attachments
  • Sean Morrison
    Sean Morrison
    2013-07-20

    Four problems identified with this patch:

    1) it's not an "svn diff" patch, you need to be working with the latest trunk sources and using svn to create your patch files.

    2) you left trailing whitespace. configure your editor to show you these turds, get a better editor, or run our sh/ws.sh script every single time you edit a file.

    3) your ID_HRT comment is useless. yes, there are other structures that also had useless comments, but that's not an excuse for new code (see HACKING). we hold new code to a higher standard.

    ... and last but not least...

    4) IT DIDN'T COMPILE! This is not acceptable. You must do better and verify your work. Check your other patches. This has been stated numerous times now and you're running out of leniency.

    That said, your patch was manually corrected and applied as r56155. Make sure any follow-up patches are based on svn trunk head so you modify the right version. Make SURE you check your other patches, make sure they apply, make sure they compile, make sure they have none of the above errors.

     
  • Sean Morrison
    Sean Morrison
    2013-07-20

    • status: open --> closed
    • assigned_to: Sean Morrison