Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#183 Small code refactoring effort

Untested
closed-fixed
Sean Morrison
None
5
2014-01-10
2013-05-20
No
1 Attachments

Discussion

  • Sean Morrison
    Sean Morrison
    2013-07-20

    I'm not sure this patch makes sense to me. Can you explain why vsu and vsv are being passed as parameters to brep_newton_joint_iterate()? It looks to me like they should have remained local to the new joint function. Also, that function should be marked static as it is not public API.

     
  • Sean Morrison
    Sean Morrison
    2013-07-20

    • status: open --> pending-rejected
     
  • Sean Morrison
    Sean Morrison
    2014-01-10

    The patch could not be applied due to the aforementioned reasons, but you did identify an unnecessary code duplication that has been eliminated in r59356.

     
  • Sean Morrison
    Sean Morrison
    2014-01-10

    • status: pending-rejected --> closed-fixed