#115 Refactoring in fb/pl-fb.c

open
nobody
None
5
2012-06-13
2012-06-13
Ksenija Slivko
No

static inline int dCoords function is added. It's called in GetDCoords and Get3DCoords. They're different because of the parameter of fprintf, so it is put as a parameter of function. Making is successful all printfs with char * are tested.

Discussion

  • Cliff Yapp
    Cliff Yapp
    2012-07-25

    Ksenija - the fread was removed from the function in this patch, as well as the assignments to coop - is that intentional?

     
  • Ksenija Slivko
    Ksenija Slivko
    2012-07-28

    Patch was updated.

     
  • Cliff Yapp
    Cliff Yapp
    2012-07-29

    I'm still seeing this patch remove the fread from GetDCoords, as well as some assignment logic - is that intentional? It looks like only lines 869 - 872 should be impacted by this, but the whole body of GetDCoords is pretty much gutted.

     
  • Ksenija Slivko
    Ksenija Slivko
    2012-07-30

    updated patch for fb/pl-fb.c

     
    Attachments