[brlcad-tracker] [ brlcad-Patches-3529853 ] Adding package size param. to /libpkg/tpkg.
Open Source Solid Modeling CAD
Brought to you by:
brlcad
From: SourceForge.net <no...@so...> - 2012-06-19 13:23:53
|
Patches item #3529853, was opened at 2012-05-25 14:18 Message generated for change (Comment added) made by erikgreenwald You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529853&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Benchmark & Performance Group: Untested >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Andrei Popescu (popescuandrei) >Assigned to: Erik Greenwald (erikgreenwald) Summary: Adding package size param. to /libpkg/tpkg. Initial Comment: Added 3rd parameter option ( package size) to tpkg.c If the param. is malformed or missing the standard 2048 size is used instead. Usage example : (as a client ) ./tpkg 127.0.0.1 myfile.txt 4096 . ---------------------------------------------------------------------- >Comment By: Erik Greenwald (erikgreenwald) Date: 2012-06-19 06:23 Message: Applied in subversion revision 51234 ---------------------------------------------------------------------- Comment By: Erik Greenwald (erikgreenwald) Date: 2012-06-19 06:23 Message: The changes provided have been applied to the latest sources and should be included in the next release of BRL-CAD. You're encouraged to make sure that the changes were applied correctly and are working as expected. Thank you for the patch! ---------------------------------------------------------------------- Comment By: Andrei Popescu (popescuandrei) Date: 2012-06-13 15:54 Message: Fixed what was mentioned in Erik's feedback. I attached a diff -w command (although it is pretty similar to the svn one ) between old tpkg and my tpkg aswell. ---------------------------------------------------------------------- Comment By: Erik Greenwald (erikgreenwald) Date: 2012-06-12 13:14 Message: uppercase variable name (TPKG_BUFSIZE) still needs to be fixed to comply with naming convention. Check for argc is wrong (should still be 2, not 4). Line 399 needs a space between the comma and pkg_size. Unnecessary formatting changes should be removed (lines 26, 87, 139, 182, 313, 320, 359). Help string needs a space between [-p#] and [-b#]. Almost there! ---------------------------------------------------------------------- Comment By: Andrei Popescu (popescuandrei) Date: 2012-06-05 07:56 Message: Feedback has been applied . example of a tpkg call : $ ./bin/tpkg -t -p 2000 -b 4096 127.0.0.1 myfile ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-27 21:40 Message: Andrei, the patch looks mostly good, but has two problems that need to be corrected before it can be applied. First, the uppercase variable name goes against our naming convention for variables (see HACKING). The uppercase would imply a preprocessor or otherwise constant symbol, which it's not. Second issue, the buffer size isn't really part of the main specification, so it should be an option (like -b bufsize), not just a trailing argument that complicates the usage. Use bu_getopt() for option parsing (hundreds of examples throughout the code or "man 3 getopt" for details). ---------------------------------------------------------------------- Comment By: Andrei Popescu (popescuandrei) Date: 2012-05-25 14:20 Message: I also modified the CMakelist.txt , forgot to mention. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529853&group_id=105292 |