[brlcad-tracker] [ brlcad-Patches-3529853 ] Adding package size param. to /libpkg/tpkg.

[SourceForge.net <no...@so...>]

Patches item #3529853, was opened at 2012-05-25 14:18
Message generated for change (Settings changed) made by popescuandrei
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529853&group_id=105292

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Benchmark & Performance
Group: Untested
>Status: Open
Resolution: Rejected
Priority: 5
Private: No
Submitted By: Andrei Popescu (popescuandrei)
Assigned to: Sean Morrison (brlcad)
Summary: Adding package size param. to /libpkg/tpkg.

Initial Comment:
Added 3rd parameter option ( package size) to tpkg.c
If the param. is malformed or missing the standard 2048 size is used instead.
Usage example : (as a client ) ./tpkg 127.0.0.1 myfile.txt 4096 .            

----------------------------------------------------------------------

Comment By: Sean Morrison (brlcad)
Date: 2012-05-27 21:40

Message:
Andrei, the patch looks mostly good, but has two problems that need to be
corrected before it can be applied.  First, the uppercase variable name
goes against our naming convention for variables (see HACKING).  The
uppercase would imply a preprocessor or otherwise constant symbol, which
it's not.
Second issue, the buffer size isn't really part of the main specification,
so it should be an option (like -b bufsize), not just a trailing argument
that complicates the usage.  Use bu_getopt() for option parsing (hundreds
of examples throughout the code or "man 3 getopt" for details).

----------------------------------------------------------------------

Comment By: Andrei Popescu (popescuandrei)
Date: 2012-05-25 14:20

Message:
I also modified the CMakelist.txt , forgot to mention.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529853&group_id=105292