From: Christopher Sean Morrison <brlcad@ma...> - 2005-08-22 23:35:50
On Tue, 23 Aug 2005, Enrique Perez-Terron wrote:
> Autogen.sh, as I got it today from cvs, contains a pair of glaring
Not sure I'd consider them glaring, seem pretty subtle actually.
Regardless, the feedback is very much appreciated.. :)
> Lines 123-131 could be improved:
> First, when QUIET is in effect, this does
> _have_sed="`: no | sed 's/no/yes/'`"
> which always yelds an empty string. The result is that
> HAVE_SED always becomes "no" if QUIET is in effect.
Good observation. That shouldn't have been the ECHO variable. That
was a remnant from an early version where ECHO was potentially more
than just 'echo'.
> Second, the test $? = 0 is always true because of the
> intervening assignment to HAVE_SED.
> I suggest instead
> [ x-yes = "x-`echo no | sed s/no/yes/ 2>/dev/null`" ] &&
Suggestion applied -- at least a close variant that follows in spirit.
If you have more changes, feel free to drop them onto the BRL-CAD
Patches tracker or send them to the dev mailing list. Thanks again!