Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#6 Add option to override the aspect ratio enforcement

closed
nobody
None
5
2008-11-12
2008-11-08
Nick Copeland
No

Bristol was giving problems with some window managers due to the enforcement of the aspect code of the bristol window. When the window is resized then the brighton library calculates another window size of the correct ratio and sends that request to the window manager then starts painting when the resize notification comes from the window manager.

This can fail when the window manager does not want to honour the request from brighton.

The resolution will either be to just paint with whatever aspect ratio is available however that will look a little gory, the other is to decide what is the best fit and leave swathes of the window blank.

Discussion

  • Nick Copeland
    Nick Copeland
    2008-11-09

    Have added an option [-ar|-aspect] which prevents libbrighton from requesting a new window size to have the correct aspect ratio. The resulting images may be gruesome since the window might be far too wide or far too long and the interface will just map the internal image into the available window space with unexpected results. This is far easier than building a best map and since the window manager here wants to dictate the window size then so be it. Attempting to build a best fit and leaving blank space would require another set of window sizing parameters and they would have to be managed under all circumstances. I prefer not to do this for the small number of window managers that give problems.

    Fix will be in the next upload. A patched version (based on 0.30.0) can be made available on request.

     
  • Nick Copeland
    Nick Copeland
    2008-11-09

    • status: open --> pending
     
  • Nick Copeland
    Nick Copeland
    2008-11-12

    • status: pending --> closed