#71 Bending notes when playing legato causes audio to silence

closed-fixed
Nick Copeland
6
2010-04-30
2010-04-26
Andrew C
No

Attempting to bend notes with the pitch wheel when playing a legato phrase (I.e the envelope hasn't reset itself) on pretty much (read: all the synths I've tried, pro1, polysix, crumar trilogy, mini, prophet52) all of the synths causes the audio to "cut out" (I ran the mini through rakarrack with distortion/delay and I could hear small 'ping pongs' of noise when I continued bending when the sound cut out).

Playing a single note, and bending causes no problems, sometimes, while playing even two notes one after another causes the audio to cut out.
I'll post an audio demo and probably the output of -mididbg and -mididbg2 soon.

Andrew Coughlan

Discussion

  • Andrew C
    Andrew C
    2010-04-26

    • labels: --> Audio Library
    • priority: 5 --> 6
     
  • Andrew C
    Andrew C
    2010-04-26

    First note gave me cut off the note and 'clicking'. The second note sustained.

     
    Attachments
  • Nick Copeland
    Nick Copeland
    2010-04-27

    Hi Andrew,

    Many thanks for submitting a very good bug report - how to reproduce, what you hear, etc.

    I have fixed a couple of bugs in the pitchbend code, there were two issues regarding different ways of tracking frequency (actual frequencies or sample steps) and most importantly an issue with frequency inversion. The latter was the main culprit: the glide rate is calculated at note_on time but naturally it can invert depending on the pitch wheel which would lead 'impossible' numbers being calculated. The calculations are not in the audio thread, they are done in the MIDI thread so the intermittent starvatation leads to clicks but not to total damage of the audio stream.

    Two files have been posted here, they can be placed on top of your 0.60.2b release. They both go in the bristol-0.60.2/bristol directory.

    Kind regards, nick

     
  • Nick Copeland
    Nick Copeland
    2010-04-27

    Patch for pitch bend errata in 0.60.2beta-1

     
    Attachments
  • Nick Copeland
    Nick Copeland
    2010-04-27

    Patch for pitch bend errata in 0.60.2beta-1

     
    Attachments
  • Nick Copeland
    Nick Copeland
    2010-04-29

    • assigned_to: nobody --> ncopeland
    • status: open --> pending-fixed
     
  • Nick Copeland
    Nick Copeland
    2010-04-29

    This is giong to be closed, code submitted to 0.60.2 and uploaded.

     
  • Nick Copeland
    Nick Copeland
    2010-04-30

    • status: pending-fixed --> closed-fixed
     
  • Nick Copeland
    Nick Copeland
    2010-04-30

    Closed