#2 Produces bad XML for konqueror

open
nobody
None
5
2004-11-19
2004-11-19
Nicholas Hardy
No

My version of Konqueror produces XML such as:

<bookmark folded="yes" netscapeinfo="
ADD_DATE=&quot;1032175475&quot;
LAST_VISIT=&quot;1072409940&quot;
LAST_MODIFIED=&quot;1032772662&quot;
ICON=&quot;http://slashdot.org/favicon.ico&quot;
LAST_CHARSET=&quot;ISO-8859-1&quot;
ID=&quot;rdf:#$nTGDA&quot;"
icon="favicons/slashdot.org" href="http://slashdot.org/"
>

However when bookmarkbridge rewrites the file it writes
it as:

<bookmark href="http://slashdot.org/" netscapeinfo="
ADD_DATE="1032175475" LAST_VISIT="1072409940"
LAST_MODIFIED="1032772662"
ICON="http://slashdot.org/favicon.ico"
LAST_CHARSET="ISO-8859-1" ID="rdf:#$nTGDA""
icon="favicons/slashdot.org">

This is not well-formed XML, and as a result Konqueror
can't load it properly.

I wrote a quick change which quotes attribute values
before writing them back. It fixes the problem for me. I
made my change in konqueror.cpp, I think it might
possibly apply to the other places you write XML
(mozilla.cpp ?). Also, I haven't dug into the code
deeply enough be sure there there isn't a better place
to fix the bug.

KDE 3.3.0, Konqueror 3.3, BookmarkBridge from cvs

Otherwise generally great software, just what I was
looking for.

Discussion

  • Nicholas Hardy
    Nicholas Hardy
    2004-11-19

    Proposed fix

     
    Attachments