Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#4 build on clang and fix scary looking bugs

open
nobody
None
5
2011-12-29
2011-12-29
alistra
No

Attaching the build.log from emerge using clang.

You should care about this, because it found some scary bugs like:

DataOutputStream.cxx:154:22: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
out.write((v ) && 0xff);
^ ~~~~
DataOutputStream.cxx:154:22: note: use '&' for a bitwise operation
out.write((v ) && 0xff);
^~
&
DataOutputStream.cxx:154:22: note: remove constant to silence this warning
out.write((v ) && 0xff);
^~~~~~~

or:
BigInteger.cxx:263:41: warning: shift count >= width of type [-Wshift-count-overflow]
return (jlong) (sign * ((data[size-2] << 32) + data[size-1]));

Discussion

  • alistra
    alistra
    2011-12-29

     
    Attachments