Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2 Memory leak in p_tool.cpp

v1.0_(example)
closed
nobody
None
5
2014-05-16
2014-04-23
Piotr Trojanek
No

Various improvements combined:
- memory leak fixed (in p_tool.cpp)
- size_t instead of int for string length
- use of C++ instead of C headers
- LaTeX log file removed

1 Attachments

Discussion

  • Ludovic DELFAU
    Ludovic DELFAU
    2014-04-24

    Hello,
    I integrated your patch by splitting it into several commits and specifying that you are the author.
    Are you using a tool to detect unnecessary includes?
    Thank you for your contribution.

     
  • Piotr Trojanek
    Piotr Trojanek
    2014-04-24

    Thanks for accepting the patch and sorry for sending all the changes as a single diff. I have modified the code before fetching bcomp's sources from SVN into a local GIT repository. Now making small commits is a lot easier for me.

    I detected unnecessary includes by manual inspection while reading the code. I suspect that an automatic tool would be confused by the "RESOURCES/p_head.h" file, which includes almost all other headers.

    The attached patch fixes yet another memory leak. This one was detected by cppcheck tool.

     
  • Ludovic DELFAU
    Ludovic DELFAU
    2014-04-25

    Your patches have been integrated. Thanks again.

     
    • status: open --> closed