[BackupPC-devel] Small error in BackupPC::Lang::en (and translations)

[Holger P. <wb...@pa...>]

Hi Craig,
hi list,

in line 43 (version 3.2.0beta0), en.pm assigns the value of
$Lang{Unable_to_connect_to_BackupPC_server} (the corresponding error message
in the language selected). This assignment has the form of

	$var = "part1",
               "part2 " . "concatenated from "
             . "several strings",     # fr.pm replaces the second "," by a "."
               "part3 ...";

Everything behind the first "," is a "useless use of a constant in void
context", if you know what I mean ;-). I suspect this was temporarily done for
testing at some point (or missed when adding language support?) and forgotten
to fix later on. The variable $Lang{Unable_to_connect_to_BackupPC_server} is
used twice in BackupPC::CGI::Lib::ServerConnect - once as first argument to
Header(), where a long text doesn't make much sense. Additionally, it is
included inside $Lang{Admin_Start_Server} (inside a <h1> tag). It seems the
content should be split up, e.g.

$Lang{Unable_to_connect_to_BackupPC_server} =
	"Unable to connect to BackupPC server";

$Lang{Unable_to_connect_to_BackupPC_server_error_message} =
	'This CGI script (\$MyURL) is unable to connect ...';

BackupPC::CGI::Lib, line 297:
ErrorExit(eval("qq{$Lang->{Unable_to_connect_to_BackupPC_server}}"),
          eval("qq{$Lang->{Unable_to_connect_to_BackupPC_server_error_message}}"));

$Lang{Admin_Start_Server} may or may not want to include the error message (I
would, but the start server message seems to say "everything is ok, you just
need to start the server", so it would make as much sense not to include the
error message).

At the very least, the part after the first "," should be removed, but I would
think including details on the error on the web page would be of advantage,
and it seems to be what was originally intended.

Regards,
Holger